add more accessibility tests #13494
Open
add more accessibility tests #13494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasberhe23
force-pushed
the
a11y-tests
branch
from
b24ad4c to
28eee9d
Compare
|
It could be good to have Alex take a look. I am not very familiar with the |
aalves08
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Left a comment. I also don't know anything about cypress-axe but at least this PR gave me opportunity to read a bit of the documentation. Nothing else stands out to me codewise.
Once we've got some tests going we can check the results and the quality of the assessment and go from there.
Good job guys! 🙏
| @@ -60,6 +60,10 @@ export default class AccountPagePo extends PagePo { | |||
| return this.self().get('button[type="reset"]').click(); | |||
| } | |||
|
|
|||
| changePasswordModal() { | |||
| return cy.get('.change-password-modal'); | |||
There was a problem hiding this comment.
we should use data-testid in order to be specific in regards to our targets. Classes can change without us realising that they are bound to a test
yonasberhe23
force-pushed
the
a11y-tests
branch
from
28eee9d to
13d53bf
Compare
yonasberhe23
force-pushed
the
a11y-tests
branch
from
13d53bf to
6411eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #rancher/qa-tasks#1639
Checklist