Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of rendering the etcd page when a no longer supported k8s version is used #13495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codyrancher
Copy link
Contributor

@codyrancher codyrancher commented Feb 24, 2025

Summary

Fixes: #13497

https://jira.suse.com/browse/SURE-9817

Technical notes summary

Properly handle missing object data

Areas or cases that should be tested

  1. Create a rancher v2.9-head instance
  2. Create a cluster with a k8s version v1.27.16+rke2r2 (DO, EC2 providers work)
  3. Upgrade the rancher instance to head
  4. Edit the cluster and then click on the etcd tab (it should now render)
    i. Without my changes I had to click between tabs a few times before the etcd tab would stop rendering.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@codyrancher codyrancher changed the title Better handling the rendering of the etcd page when a no longer suppo… Better handling the rendering of the etcd page when a no longer supported k8s version is used Feb 24, 2025
@codyrancher codyrancher added this to the v2.11.0 milestone Feb 24, 2025
@codyrancher codyrancher changed the title Better handling the rendering of the etcd page when a no longer supported k8s version is used Better handling of rendering the etcd page when a no longer supported k8s version is used Feb 24, 2025
@codyrancher codyrancher marked this pull request as ready for review February 25, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot see all values when editing config
1 participant