Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace extension menu with ActionMenuShell.vue #13505

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Feb 25, 2025

Summary

This replaces the extensions menu with the ActionMenuShell component. Using the new action menu component provides us with out of the box accessibility features and keyboard navigation.

Fixes #13504

Occurred changes and/or fixed issues

  • Accept custom actions in ActionMenuShell
  • Replace extensions menu with ActionMenuShell

Technical notes summary

The design of the existing action menu operates in such a way that emitted events are not declared. I attempted to find a way to work around the Vue warnings we receive when emitting events in this way, but we might need to refactor how custom actions are emitted. I'm open to suggestions on how to resolve this without requiring a larger refactor.

Areas or cases that should be tested

  • Extensions menu

Areas which could experience regressions

  • Extensions menu

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work as intended @rak-phillip but there's a couple of things popping up on the console:

When I open it I get
Screenshot 2025-02-25 at 18 14 53

And if I click Manage Repositories the console get quite a few warnings like
Screenshot 2025-02-25 at 18 15 14

@rak-phillip
Copy link
Member Author

It seems to work as intended @rak-phillip but there's a couple of things popping up on the console:

When I open it I get Screenshot 2025-02-25 at 18 14 53

This is what I'm attempting to call out in the technical notes section of the PR description

Technical notes summary

The design of the existing action menu operates in such a way that emitted events are not declared. I attempted to find a way to work around the Vue warnings we receive when emitting events in this way, but we might need to refactor how custom actions are emitted. I'm open to suggestions on how to resolve this without requiring a larger refactor.

The action menu is designed in such a way that events are emitted dynamically; this makes it difficult to satisfy the constraint of explicitly defining emits without requiring a larger refactor in how the action menu behaves.. I'm open to suggestions and ideas at this point.

And if I click Manage Repositories the console get quite a few warnings like Screenshot 2025-02-25 at 18 15 14

hmmm.. I see this now, I'll have to investigate to better understand the root cause

@rak-phillip rak-phillip requested a review from aalves08 February 25, 2025 20:31
@rak-phillip
Copy link
Member Author

rak-phillip commented Feb 25, 2025

@aalves08 I think that I resolved the second issue that you noted via 7f7603d, can you take a look and confirm?

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mate! let's chat about the problem that you described in your technical details tomorrow 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace extensions menu with dropdown menu
2 participants