Import EKS clusters #13517
Open
Import EKS clusters #13517
+329
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -596,7 +635,7 @@ export default defineComponent({ | |||
| <LabeledInput | |||
| required | |||
| label-key="eks.clusterName.label" | |||
| :value="config.displayName" | |||
| :value="normanCluster.name" | |||
There was a problem hiding this comment.
config.displayName = eks cluster name in aws (set by the Import component)
normanCluster.name = rancher cluster object's name
| } | ||
|
|
||
| const clusterNameRequired = (ctx: CruEKSContext) => { | ||
| return (): string | null => { | ||
| return !ctx.config.displayName ? ctx.t('validation.required', { key: ctx.t('nameNsDescription.name.label') }) : null; | ||
| return !ctx.normanCluster.name ? ctx.t('validation.required', { key: ctx.t('nameNsDescription.name.label') }) : null; |
There was a problem hiding this comment.
validate the name field that the user types instead of the displayName, which may come from eks API
mantis-toboggan-md
force-pushed
the
eks-import
branch
from
9fc85f4 to
2834843
Compare
codyrancher
reviewed
Feb 27, 2025
| <template> | ||
| <div class="row mb-10 align-center"> | ||
| <div class="col span-6"> | ||
| <LabeledSelect |
There was a problem hiding this comment.
I think we want to make this a required field, it can't think of a scenario where we wouldn't want it.
Without it we'll get an error:
codyrancher
requested changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12409
Occurred changes and/or fixed issues
Similar to #13447
Areas or cases that should be tested
For testing purposes you should be to use my existing eks cluster
nb-eksinn theus-west-2region2 Select EKS
5.Try selecting different regions - the cluster dropdown should reload (you should see aws api calls in the network tab)
7.Add users, labels and annotations as well
Areas which could experience regressions
The existing EKS cluster creation flow should be tested.
Screenshot/Video
Checklist