Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12811
Occurred changes and/or fixed issues
223
, focus trap onLabeledSelect
insideImport Extension Catalog
modal by refactoring the mechanism to preventescape
key handler on modals based on other UI elements likeCodeMirror
andLabeledSelect
. Architecture is now only based on preventing propagation of events 🪄Should be tested also the
Import YAML
modal since it features bothLabeledSelect
andCodeMirror
as UI elements that have the need to prevent thatescape
key handler onAppModal
177
fixed on a previous PR166
by improving aria-label's for theButtonGroup
155
and179
by allowingLabeledInput
to pass anaria-label
as a prop ofLabeledInput
. This covers the cases whereLabeledInput
is used without a label145
by adding the necessary a11y attributes and allowing keyboard interaction with arrow keys to resize the shell console windowTechnical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist