Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misc issues for a11y #13519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Feb 26, 2025

Summary

Fixes #12811

Occurred changes and/or fixed issues

  • Fixes a11y issue 223, focus trap on LabeledSelect inside Import Extension Catalog modal by refactoring the mechanism to prevent escape key handler on modals based on other UI elements like CodeMirror and LabeledSelect. Architecture is now only based on preventing propagation of events 🪄

Should be tested also the Import YAML modal since it features both LabeledSelect and CodeMirror as UI elements that have the need to prevent that escape key handler on AppModal

  • a11y issue 177 fixed on a previous PR
  • Fixes a11y issue 166 by improving aria-label's for the ButtonGroup
  • Fixes a11y issue 155 and 179 by allowing LabeledInput to pass an aria-label as a prop of LabeledInput. This covers the cases where LabeledInput is used without a label
  • Fixes a11y issue 145 by adding the necessary a11y attributes and allowing keyboard interaction with arrow keys to resize the shell console window

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 requested a review from rak-phillip February 26, 2025 16:46
@aalves08 aalves08 self-assigned this Feb 26, 2025
@aalves08 aalves08 added this to the v2.11.0 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant