Fix SSH Key missing fields #13520
Open
Fix SSH Key missing fields #13520
+129
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchiaf
force-pushed
the
13474-secrets
branch
from
b15a0a3 to
f76b421
Compare
torchiaf
commented
Feb 26, 2025
| @@ -44,7 +44,10 @@ export default { | |||
| update() { | |||
| this.value.setData('ssh-publickey', this.username); | |||
| this.value.setData('ssh-privatekey', this.password); | |||
| this.value.setData('known_hosts', this.knownHosts); | |||
| if (this.showKnownHosts) { | |||
There was a problem hiding this comment.
With this, the known_hosts field will be visible only when editing a secret that already has known_hosts key in data, so not visible on creation.
The other solution is to enable it by default.
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
torchiaf
force-pushed
the
13474-secrets
branch
from
f76b421 to
6708040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13474
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist