Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update focus styles for inputs #13523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Feb 26, 2025

Summary

This updates focus styles for inputs to match the updated design and colors.

Fixes #13522

Occurred changes and/or fixed issues

  • Add new colors, waterhole & waterhole-60
  • Change display of inputs from display: table to display: flex
  • Update focus ring offset
  • Add focus ring to select component

Technical notes summary

In order to resolve an issue with displaying the focus ring in Firefox, we had to update the display of the labeled input from table to flex. This change requires some additional style updates. For example, the password input needed some additional changes to properly display the show/hide toggle.

Areas or cases that should be tested

  • Inputs & Selects
  • Forms

Areas which could experience regressions

  • Labeled Input

Screenshot/Video

Before

image

After

image

image

image

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

`display: table` caused the outline border to always be square in Firefox. For the purpose of the inputs, `display: flex` makes more sense while consistently displaying across browsers.

Signed-off-by: Phillip Rak <[email protected]>
@rak-phillip
Copy link
Member Author

@kwwii let me know if you'd like to sync so we can give this one a review. I'm trying to limit the scope of this change to just the focus ring that inputs receive, but I'm also noting some inconsistencies with colors used for borders and labels (see screenshots). Changing these colors will have knock-on effects for other areas of Dashboard, so I'm looking for feedback on how much we really want to change at this point.

FYI - @edenhernandez-suse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Focus color on inputs
1 participant