Adding the ability to configure resource sets to resources.cattle.io.backup
#13525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyrancher
force-pushed
the
backup-resourceset
branch
from
49ee1e1 to
9986c3c
Compare
nwmac
requested changes
Feb 27, 2025
| enableEncryptionWarning: 'Enabling encryption is highly recommended when using <b><i>Full Rancher backup resource set</i></b>, otherwise sensitive information will be backed up as plain-text. <a target="_blank" rel="noopener noreferrer nofollow" href="https://ranchermanager.docs.rancher.com/reference-guides/backup-restore-configuration/backup-configuration#resourcesets">Read more</a>.' | ||
| missingResourceSetWarning: The <b><i>{resourceSet}</i></b> resource set doesn't exist, it's possible it has been deleted. Please select a different option. | ||
| resourceSetOptions: | ||
| 'rancher-resource-set': 'Default Rancher backup resource set' |
There was a problem hiding this comment.
This needs to be rancher-resource-set-basic - suggest we change the label to 'Basic Rancher backup restore set`
|
This looks good - tested it and changes are great. Once change needed - my mistake reading the requirements - the basic set should be
I added a comment for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the ability to configure resource sets to
resources.cattle.io.backupFixes: #12997
Areas or cases that should be tested
You'll need to install the
Rancher Backupapp first.resources.cattle.io.backupedit/detail page.resources.cattle.io.resourceset. To create I just cloned the existing and changed the name field in the yaml.Areas which could experience regressions
Screenshot/Video
resource-set.mp4
Forgot to include deleting the selected resource in the video:
Checklist