Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way that the heading modifiers are applied #18

Open
raphaelcruzeiro opened this issue Jan 23, 2014 · 4 comments
Open

Improve the way that the heading modifiers are applied #18

raphaelcruzeiro opened this issue Jan 23, 2014 · 4 comments
Milestone

Comments

@raphaelcruzeiro
Copy link
Owner

On 0.5, when the heading button is clicked, the whole line becomes the heading and not just the selection. The desired behaviour in this case would be to split the p element and create the heading with only the selected text.

@otaviosoares otaviosoares modified the milestones: 0.6, 1.0 Feb 14, 2014
@sonofpaul
Copy link

After making some text a header, it is not very obvious how to change it back to regular text. As far as I could tell, there is no way to do that. I would recommend clicking on the header button a second time as a way to "turn off" the header.

@raphaelcruzeiro
Copy link
Owner Author

This should be the default behaviour. If I select a text formatted as an h1, the h1 button should be green. If I click the button the header formatting should be removed.

If this is indeed not working, please tell me your browser and version.

Thanks,

@sonofpaul
Copy link

Try this. In Chrome (Windows 8 or Mac), go here:
http://raphaelcruzeiro.github.io/jquery-notebook/

Highlight the word "released".
Select the "bullet" button.
Select the H2 button.
Select the H2 button again.

For me, it seems to double the formatting rather than remove it.

@raphaelcruzeiro
Copy link
Owner Author

Interesting. This happens only if the header format is applied on a list item.
I'll create an issue to address this behaviour and mark it as a bug.

Thanks for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants