-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dedicated histogram plotting function #77
Comments
yep, I agree that it should be possible to allow using the "histogram on top of a colorbar" feature independent of EOmaps. (Could be quite useful as an "enhanced colorbar" for arbitrary matplotlib plots.) However, there are still some open tasks in that feature that would be good to address as well:
If I find the time I'll look into this... meanwhile projects are always welcome! 🙂 |
I agree, but I would add that the default colorbar should be the "expected" colorbar, while the histogram one should be an opt-in feature. I recently faced a problem using the colorbar where some text labels from the histogram axes kept floating around even when IMO, one of the first steps here is to detach the requirement of having a histogram axis from the Colorbar class and down the rendering tree. @raphaelquast, do you agree? I got some light changes here but I can probably build on top if this aligns with your view. |
Hey @ocehugo thanks for following up on this issue!
Personally I really like the histogram-based colorbar... but I agree that this is not always desired and that there should be an easy way to get a plain simple colorbar. If colorbar & histogram are added with a single method, I'd rather keep the existing default for backward compatibility. However, even though this would be a bigger API change, it might actually be a good idea to actually have 2 dedicated methods, e.g.:
This would make the methods much more concise and simplify fine-grained control of the colorbar/histogram.
Yes I fully agree!
I highly appreciate any contributions from your side that result in a better handling of colorbars and histograms! |
the histogram plot (implemented here) using a custom colorbar should be a dedicated function that can be easily used externally by passing the correct arguments, since it can be quite useful for other (non-map) plots as well
The text was updated successfully, but these errors were encountered: