Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] 32bits indices dispatch mechanism for UMAP #6310

Closed
viclafargue opened this issue Feb 11, 2025 · 1 comment
Closed

[FEA] 32bits indices dispatch mechanism for UMAP #6310

viclafargue opened this issue Feb 11, 2025 · 1 comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@viclafargue
Copy link
Contributor

Following #6245, many operations will be done with 64 bits indices in UMAP. Optimally, 32 bits indices should instead be used for smaller datasets. This issue is a reminder to implement a dispatching mechanism that depends on the number of rows in the input dataset.
@viclafargue viclafargue added ? - Needs Triage Need team to review and classify feature request New feature or request labels Feb 11, 2025
This was referenced Feb 13, 2025
Merged
Merged
rapids-bot bot pushed a commit that referenced this issue Feb 14, 2025
@viclafargue
UMAP 32bits dispatch mechanism (#6314)
8a5feaa 
Answers #6310

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #6314
@jcrist
Copy link
Member

jcrist commented Feb 14, 2025

Fixed by #6314. Closing.

@jcrist jcrist closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcrist @viclafargue