Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong browser version/ No browsers installed #64

Open
aumeshm opened this issue Nov 14, 2024 · 3 comments
Open

Wrong browser version/ No browsers installed #64

aumeshm opened this issue Nov 14, 2024 · 3 comments

Comments

@aumeshm
Copy link

aumeshm commented Nov 14, 2024

When doing yarn for a clean repo, the browser doesn't get downloaded.

Now if someone installs a later puppeteer version than the one rebrowser is on, then we get an error when they transition over to rebrowser, which is somewhat to be expected.

Wondering if rebrowser should also be responsible for downloading the right browser version that the package should run on.

@aumeshm aumeshm changed the title Installing rebrowser from scratch installs wrong browser version Wrong browser version/ No browsers installed Nov 14, 2024
@nwebson
Copy link
Contributor

nwebson commented Nov 14, 2024

What package do you use? rebrowser-puppeteer is the original puppeteer package with just the patches applied, it doesn't change anything with browser download process, so it should work fine. Same applies to rebrowser-playwright package.

@aumeshm
Copy link
Author

aumeshm commented Nov 26, 2024

We had someone have a different of puppeteer, and they had a diff version of chrome installed. Then we migrated to rebrowser-puppeteer which used a lower version of chrome, but I don't believe it downloaded the version of chrome needed for rebrowser.

@nwebson
Copy link
Contributor

nwebson commented Dec 5, 2024

Please share a full list of steps how to reproduce this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants