Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to perform outer loop build/deploy with CLI args, (without changing contents of devfile) #5080

Closed
1 task
scottkurz opened this issue Sep 20, 2021 · 4 comments
Labels
area/outerloop Issues or PRs related to outer-loop use cases kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@scottkurz
Copy link
Contributor

/kind user-story

User Story

As an application deployer (e.g. perhaps in writing a pipeline build task), I want to perform an image build and deploy (or possibly build only) with substitutions for devfile variables provided at build time. (I don't want to necessarily have to express my customization as a devfile file, even using child/parent extension).

This would be analogous to docker build-arg, e.g.: docker build --build-arg abc=123.

Acceptance Criteria

  • odo should allow a CLI argument to be passed to override a devfile variable value, and to use this value in all aspects of outer loop build and/or deploy.

Links

  • Related Epic (mandatory): ?
  1. This would prereq and build on the support described here: Add odo deploy command for initial transition from inner to outer loop #2756 , (now making its way into devfile library, e.g. here: Dockerfile Outerloop Support devfile/api#580)
  2. This might leverage Add ability to view/set devfile variables via subcommand like: odo config view/set  #4838, which could be a sort of "soft" prereq.

NOTE:

This could also prompt the question "why not allow this on other commands?", e.g. "push" and "test". This could get tricky because of pod state... e.g. 'push' may or may not start a new pod.. should it try to be smart about deciding whether to if the devfile variable values change? OTOH, 'test' does not ever start a new pod.. so is it safer (if possibly wrong / user error) to allow new variable values? Some things to think about...

/kind user-story

@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Sep 20, 2021
@kadel kadel added priority/Medium Nice to have issue. Getting it done before priority changes would be great. area/outerloop Issues or PRs related to outer-loop use cases labels Sep 21, 2021
@yangcao77
Copy link
Contributor

Devfile library release contains outerloop support: https://github.com/devfile/library/releases/tag/v1.2.0

@rm3l
Copy link
Member

rm3l commented Sep 2, 2022

I think this has been addressed with the variable substitution feature we added in v3 to odo dev and odo deploy commands.
See https://odo.dev/docs/command-reference/dev#substituting-variables and https://odo.dev/docs/command-reference/deploy#substituting-variables

ref #5489

@rm3l rm3l added this to odo Project Oct 3, 2022
@rm3l rm3l moved this to To Do 📝 in odo Project Oct 3, 2022
@rm3l rm3l removed the status in odo Project Oct 3, 2022
@rm3l
Copy link
Member

rm3l commented Nov 2, 2022

Closing this issue as completed in v3.0.0 (#5489), but feel free to reopen if you think otherwise.

FYI, there is a separate issue for also supporting variable substitution when performing image builds: #6274

/close

@openshift-ci openshift-ci bot closed this as completed Nov 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2022

@rm3l: Closing this issue.

In response to this:

Closing this issue as completed in v3.0.0 (#5489), but feel free to reopen if you think otherwise.

FYI, there is a separate issue for also supporting variable substitution when performing image builds: #6274

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot moved this to Done ✅ in odo Project Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/outerloop Issues or PRs related to outer-loop use cases kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Development

No branches or pull requests

4 participants