Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow executing non-default deploy commands #5454

Open
1 task
kadel opened this issue Feb 11, 2022 · 5 comments · Fixed by #5460
Open
1 task

Allow executing non-default deploy commands #5454

kadel opened this issue Feb 11, 2022 · 5 comments · Fixed by #5460
Labels
kind/user-story An issue of user-story kind lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@kadel
Copy link
Member

kadel commented Feb 11, 2022

/kind user-story
/label v3
/priority medium

User Story

As an odo user, I want to be able to execute alternative deploy command that is not marked as default So that I can run/test alternative deploy commands without editing devfile.yaml

Acceptance Criteria

  • It should be possible to specify alternative deploy command via a flag on odo deploy command (for example odo deploy --command altdeploy

example

commands:
  - id: deploy
    composite:
        commands:
          - build-image-stack-provided
          - outerloop-deploy
        group:
          kind: deploy
          isDefault: true
  - id: deploy-app-image
    composite:
       commands:
         - build-image-app-provided
         - outerloop-deploy
       group:
         kind: deploy
         isDefault: false
  • odo deploy should execute command id: deploy, because it is kind: deploy command marked with isDefualt:true
  • odo deploy --command deploy-app-image should execute command id: deploy-app-image

Links

/kind user-story

@openshift-ci openshift-ci bot added kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Feb 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2022

@kadel: The label(s) /label v3 cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/kind user-story
/label v3
/priority medium

User Story

As an odo user, I want to be able to execute alternative deploy command that is not marked as default So that I can run/test alternative deploy commands without editing devfile.yaml

Acceptance Criteria

  • It should be possible to specify alternative deploy command via a flag on odo deploy command (for example odo deploy --command altdeploy

example

commands:
 - id: deploy
   composite:
       commands:
         - build-image-stack-provided
         - outerloop-deploy
       group:
         kind: deploy
         isDefault: true
 - id: deploy-app-image
   composite:
      commands:
        - build-image-app-provided
        - outerloop-deploy
      group:
        kind: deploy
        isDefault: false
  • odo deploy should execute command id: deploy, because it is kind: deploy command marked with isDefualt:true
  • odo deploy --command deploy-app-image should execute command id: deploy-app-image

Links

/kind user-story

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 1, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Dec 1, 2023
@rm3l
Copy link
Member

rm3l commented Dec 7, 2023

/reopen
/remove-lifecycle stale
/remove-lifecycle rotten
/lifecycle frozen

Still relevant - see thread in https://kubernetes.slack.com/archives/C01D6L2NUAG/p1701792255438769

@openshift-ci openshift-ci bot reopened this Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

@rm3l: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle stale
/remove-lifecycle rotten
/lifecycle frozen

Still relevant - see thread in https://kubernetes.slack.com/archives/C01D6L2NUAG/p1701792255438769

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2023
@github-project-automation github-project-automation bot moved this from Done ✅ to To Do 📝 in odo Project Dec 7, 2023
@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Dec 7, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Dec 7, 2023
@rm3l rm3l removed the status in odo Project Dec 7, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants