Odo does not apply multiple deploy commands

[yangcao77]

/kind bug

What versions of software are you using?

Operating System:

Output of odo version: odo v2.5.0 (2bd4f07)

How did you run odo exactly?

run odo deploy with a devfile having 2 deploy commands defined, one default, and one non-default.

  - id: deploy
    composite:
        commands:
          - build-image-stack-provided
          - outerloop-deploy
        group:
          kind: deploy
          isDefault: true   
  # Deploy an app image built with a developer provided dockerfile - non-default action
  - id: deploy-app-image
    composite:
       commands:
         - build-image-app-provided
         - outerloop-deploy
       group:
         kind: deploy

Actual behavior

Seeing error:

$ odo deploy
 ✗  more than one default deploy command found in devfile, should not happen

However, I have one and only one default deploy command defined in devfile.
It is because Odo does not check for isDefault property, only checks for length of deploy commands.

odo/pkg/devfile/adapters/kubernetes/component/adapter.go

Lines 855 to 860 in ce9506d

	if len(deployGroupCmd) == 0 {
	return devfilev1.Command{}, &NoDefaultDeployCommandFoundError{}
	}
	if len(deployGroupCmd) > 1 {
	return devfilev1.Command{}, &MoreThanOneDefaultDeployCommandFoundError{}
	}

Expected behavior

Odo should allow multiple deploy commands, but only one isDefault

Any logs, error output, etc?

[yangcao77]

/area deploy

[kadel]

/triage duplicate

#5452

/close

[openshift-ci]

@kadel: Closing this issue.

In response to this:

/triage duplicate

#5452

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.