Don't save component name in `env.yaml.

[kadel]

The only thing that should control the name of the component is metadata.name in devfile.yaml.

Change the metadata.name and run odo dev again.

/kind bug
/priority high

[valaparthvi]

odo/pkg/odo/cli/dev/dev.go

Lines 145 to 146 in d5935a1

	// TODO - store only namespace into env.yaml, we don't want to track component or application name via env.yaml
	err = envfileinfo.SetComponentSettings(envinfo.ComponentSettings{Name: cmpName, Project: o.GetProject(), AppName: "app"})

If it is of any help.

[dharmit]

From the comment #5862 (comment):

I think that #5780 is still valid. What we are currently doing (saving name in env.yaml) is not good, and it creates a lot of o problems. It still make sense to not save name and just use name from devfile.

@kadel can you explain what problems are we/users seeing because of storing the name in env.yaml? I looked at the issue description, but couldn't find any. I'm sure that something must have led you to open a high priority bug, but there's not enough information on this issue for a bug.

[kadel]

@kadel can you explain what problems are we/users seeing because of storing the name in env.yaml? I looked at the issue description, but couldn't find any. I'm sure that something must have led you to open a high priority bug, but there's not enough information on this issue for a bug.

devfile.yaml should be the main source of through. Current behavior leads to inconsistencies and it can be confusing for users.

▶ odo init --name myapp --devfile java
# name your component "myapp"

▶ odo list
 ✓  Listing components from namespace 'tkral-dev' [5s]
 NAME     PROJECT TYPE  RUNNING IN  MANAGED
 * myapp  maven         None        odo

▶ odo dev
  __
 /  \__     Developing using the myapp Devfile
 \__/  \    Namespace: tkral-dev
 /  \__/    odo version: v3.0.0-beta1
 \__/
...
...
...

# deployed as a "myapp"

▶ odo list
 ✓  Listing components from namespace 'tkral-dev' [4s]
 NAME     PROJECT TYPE  RUNNING IN  MANAGED
 * myapp  maven         Dev         odo


# change metadata.name in devfile to "somethingelse"

▶ odo list
 ✓  Listing components from namespace 'tkral-dev' [5s]
 NAME             PROJECT TYPE  RUNNING IN  MANAGED
 * somethingelse  maven         None        odo

# correctly shows the component as "somethingelse", as user I think "that is ok, that is my value I set in devfile"

▶ odo dev
  __
 /  \__     Developing using the somethingelse Devfile
 \__/  \    Namespace: tkral-dev
 /  \__/    odo version: v3.0.0-beta1
 \__/
....
....

# notice that it says "somethingelse" on the first line, everything is still ok.
The value of `metadata.name` was used everywhere where it is visible to the user.

▶ kubect get deployment
NAME                READY   UP-TO-DATE   AVAILABLE   AGE
somethingelse-app   1/1     1            1           70s

# even the name of the deployment is named after `metadata.name`


▶ odo list
 ✓  Listing components from namespace 'tkral-dev' [4s]
 NAME             PROJECT TYPE  RUNNING IN  MANAGED
 * somethingelse  maven         Dev         odo
 myapp            Unknown       Dev         odo


# WTF?, why are there two components?

There simply is no reason to have a separate field for name.
The name of the component that is created should always follow what users sets in devfile.
Names of k8s resources are a different story, they don't need to match the devfile name (and if we want to address #5862 they can't match devfile name).
But important is that for users using odo the component displays the name they set in devfile.

[dharmit]

Thanks for that explanation. Makes sense. 👍🏾