Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build on Ubuntu 22.04 (Jammy) #4298

Closed
umanwizard opened this issue Apr 16, 2022 · 8 comments
Closed

Can't build on Ubuntu 22.04 (Jammy) #4298

umanwizard opened this issue Apr 16, 2022 · 8 comments
Labels
community kind/bug Something isn't working

Comments

@umanwizard
Copy link

umanwizard commented Apr 16, 2022

build.sh fails due to this issue: catchorg/Catch2#2178

(Catch2 is depended on by cppkafka within redpanda)

JIRA Link: CORE-888

@umanwizard umanwizard added the kind/bug Something isn't working label Apr 16, 2022
@emaxerrno
Copy link
Contributor

@umanwizard did you try to update cppkafka in oss.cmake hash to see if the latest has the catch 22 fixes. Also not sure if cppkafka can disable tests and not pull that dependency

@umanwizard
Copy link
Author

cppkafka's latest origin/master suffers from the same issue, which I have now filed upstream: mfontanini/cppkafka#294 .

Will try disabling tests.

@umanwizard
Copy link
Author

cppmake build succeeds with this change:

diff --git a/cmake/oss.cmake.in b/cmake/oss.cmake.in
index 53856c61d..f09177a75 100644
--- a/cmake/oss.cmake.in
+++ b/cmake/oss.cmake.in
@@ -259,7 +259,7 @@ ExternalProject_Add(
 
 ExternalProject_Add(cppkafka
   GIT_REPOSITORY https://github.com/mfontanini/cppkafka.git
-  GIT_TAG c3b4580
+  GIT_TAG 5a119f6
   INSTALL_DIR @REDPANDA_DEPS_INSTALL_DIR@
   DEPENDS librdkafka
   CMAKE_COMMAND ${CMAKE_COMMAND} -E env ${cmake_build_env} ${CMAKE_COMMAND}
@@ -269,7 +269,7 @@ ExternalProject_Add(cppkafka
     -DCPPKAFKA_RDKAFKA_STATIC_LIB=ON
     -DCPPKAFKA_BOOST_STATIC_LIBS=OFF
     -DCPPKAFKA_DISABLE_EXAMPLES=OFF
-    -DCPPKAFKA_DISABLE_TESTS=OFF)
+    -DCPPKAFKA_DISABLE_TESTS=ON)
 

However, now I am hitting issues building in v8; will file a separate issue.

@dotnwat
Copy link
Member

dotnwat commented Apr 17, 2022

However, now I am hitting issues building in v8; will file a separate issue.

We disabled the v8 build temporarily internally. @VadimPlh did we do this for the open-source build?

@VadimPlh
Copy link
Contributor

VadimPlh commented Apr 18, 2022

However, now I am hitting issues building in v8; will file a separate issue.

We disabled the v8 build temporarily internally. @VadimPlh did we do this for the open-source build?

No, I did not switch off v8 in public build.
Let me do it

@emaxerrno
Copy link
Contributor

@VadimPlh we should also disable the tests of cppkafka

@emaxerrno
Copy link
Contributor

and take the patch from @umanwizard 's suggestion on updating the latest hash.

@dotnwat
Copy link
Member

dotnwat commented Apr 4, 2024

Open source build is much better now, and we don't have the catch2 dependency. Let us know if you face additional challenges.

@dotnwat dotnwat closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants