Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #3

Open
2 tasks
Moneyl opened this issue Sep 9, 2023 · 0 comments
Open
2 tasks

Improve error handling #3

Moneyl opened this issue Sep 9, 2023 · 0 comments

Comments

@Moneyl
Copy link
Collaborator

Moneyl commented Sep 9, 2023

Error handling needs to be improved. Right now there's several places where functions can return a .Err result and leave it unhandled, crashing the app. There's also no way for it to log additional info to the application using it.

  • Add logging event so RfgTools can log errors and information and apps that use it can add an event handler to pass them through their own logging system.
  • Go through code and make sure all functions that return a Result<> type are handling the error case. Change the functions to return Result<> themselves if necessary. Could use the Try!() mixin to simplify the code in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Next version
Development

No branches or pull requests

1 participant