Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make approve step optional in addWeight #1

Open
hobofan opened this issue Oct 1, 2018 · 1 comment
Open

make approve step optional in addWeight #1

hobofan opened this issue Oct 1, 2018 · 1 comment

Comments

@hobofan
Copy link
Member

hobofan commented Oct 1, 2018

Calling rlay.addWeight currently submits two transactions:

  • approve call to set the allowance for the RlayToken contract
  • Submiting the propostion weight

The first step was intended as a convenience feature, but can actually lead to problems when trying to use addWeight in parallel. It can also lower the allowance from a previously higher value, which can be an unwanted side-effect.

So the first step should be optional and also off by default (and maybe be extended to check if it is even required).

hobofan added a commit that referenced this issue Oct 1, 2018
@hobofan
Copy link
Member Author

hobofan commented Oct 2, 2018

414ff91 changed the behaviour to not set the allowance by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant