Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable sanity checks for argument parser #36

Open
vepadulano opened this issue Jul 27, 2023 · 0 comments
Open

Re enable sanity checks for argument parser #36

vepadulano opened this issue Jul 27, 2023 · 0 comments
Assignees

Comments

@vepadulano
Copy link
Member

We used to have some sanity checks for the arguments being passed such as

if ARGS.scheduling_mode == "dask-ssh":
if not ARGS.nodes:
raise ValueError("For SSHCluster deployments, please specify a "
"string with a comma-separated list of hostnames of nodes that will be used.")
if ARGS.npartitions is None:
n_compute_nodes = len(ARGS.nodes.split(",")) - 1
ARGS.npartitions = ARGS.ncores * n_compute_nodes
elif ARGS.scheduling_mode == "dask-local":
if ARGS.npartitions is None:
ARGS.npartitions = ARGS.ncores

I believe we should reinstate these checks and possibly add even more

@vepadulano vepadulano self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant