Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export set_data_directory() and document it in the README #211

Open
agila5 opened this issue Oct 20, 2021 · 2 comments
Open

Export set_data_directory() and document it in the README #211

agila5 opened this issue Oct 20, 2021 · 2 comments

Comments

@agila5
Copy link
Collaborator

agila5 commented Oct 20, 2021

I think set_data_directory() is an extremely useful function to set a persistent directory for stats19, but it's not exported:

remotes::install_github("ropensci/stats19", quiet = TRUE)
library(stats19)
#> Data provided under OGL v3.0. Cite the source and link to:
#> www.nationalarchives.gov.uk/doc/open-government-licence/version/3/
stats19::set_data_directory
#> Error: 'set_data_directory' is not an exported object from 'namespace:stats19'

Created on 2021-10-20 by the reprex package (v2.0.1)

I think we could 1) export the function and 2) add an example in the README. I can add a PR if you want.

@Robinlovelace
Copy link
Member

I can add a PR if you want.

Big +1 to that idea!

@Robinlovelace
Copy link
Member

After #210 is fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants