Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.17 fails to build on 1.80 with --locked #239

Closed
newAM opened this issue Aug 10, 2024 · 4 comments
Closed

v0.3.17 fails to build on 1.80 with --locked #239

newAM opened this issue Aug 10, 2024 · 4 comments

Comments

@newAM
Copy link
Member

newAM commented Aug 10, 2024

cargo install svdtools --locked with rustc v1.80

Results in:

error[E0282]: type annotations needed for `Box<_>`
  --> /home/alex/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

Would it be possible to get a crates.io release to update the lockfile? I maintain the NixOS package for svdtools, and NixOS builds with the release lockfile.

@burrbull
Copy link
Member

I do not like the idea to add Cargo.lock to master branch.

But it makes sense to add it in releases (on crates.io and Github Releases). Could it be done by some deploy CI?
cc @Emilgardis
Related RP: #204

@newAM I want merge #238 before release. But it is blocked by stm32-rs/stm32-rs#1002

@Emilgardis
Copy link
Member

A lockfile will always be provided when cargo publishing, so nothing needs to be changed really

@burrbull
Copy link
Member

@newAM released.

@newAM
Copy link
Member Author

newAM commented Aug 10, 2024

Thanks!

@newAM newAM closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants