You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was removed in this commit because ID-based hashing and equality conflicted with with rust-analyzer's interner, which outlives the Salsa database in tests. Once rust-analyzer gets rid of its native interner in favor of Salsa's interner, then I think it'd safe to re-add this functionality. Alternatively, we can reimplement #[salsa::Supertype] as an attribute macro (instead of a derive) and add options to disable deriving Hash/Equality, but I'm too lazy to do that right now.
The text was updated successfully, but these errors were encountered:
After #677 lands, we should re-add the following code to
#[salsa:Supertype]
:It was removed in this commit because ID-based hashing and equality conflicted with with rust-analyzer's interner, which outlives the Salsa database in tests. Once rust-analyzer gets rid of its native interner in favor of Salsa's interner, then I think it'd safe to re-add this functionality. Alternatively, we can reimplement
#[salsa::Supertype]
as an attribute macro (instead of a derive) and add options to disable derivingHash
/Equality
, but I'm too lazy to do that right now.The text was updated successfully, but these errors were encountered: