Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeletedEntries always deallocates all blocks #733

Open
Veykril opened this issue Feb 26, 2025 · 0 comments
Open

DeletedEntries always deallocates all blocks #733

Veykril opened this issue Feb 26, 2025 · 0 comments

Comments

@Veykril
Copy link
Member

Veykril commented Feb 26, 2025

We currently use crossbeams SeqQueue for our DeletedEntries management (deferred dropping) which general seems like a fine choice. Unfortunately when we get to cleaning up we right now replace the entire queue and drop it, meaning we discard all blocks where as keeping the allocation for the first would be beneficial for workloads where only a small number of elements change. SeqQueue itself doesn't support that even if we did pop each element off one by one as it deallocates blocks the moment they become empty.

Might be worth exploring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant