[TEST FAILURE] Mac OS tests failing on GH Hosted Runners

[barneysowood]

Mac OS tests are failing since work to move CI from AWS to GH Hosted Runners.

Work being done by @dwoz in #67114 - still seeing failing Mac OS tests in test runs related to that PR, eg https://github.com/saltstack/salt/actions/runs/12698967172/job/35399479072

Open this issue to cover tracking the issue with tests on Mac OS

[barneysowood]

Issue can be assigned to me.

[barneysowood]

Found pre-migration test run where the tests are passing:

https://github.com/saltstack/salt/actions/runs/11545108391/job/32132765850

In the failing job the test that is failing gives this error:

2025-01-09T22:08:18.9420890Z ERROR tests/pytests/unit/states/test_service.py -
FileNotFoundError: [Errno 2] No such file or directory: 'systemctl'

Looking for that test in the pre-migration tests, I see:

2024-10-28T01:17:42.8086800Z SKIPPED [1] tests/pytests/unit/states/test_service.py:681:
service.running is currently failing on OSX

So looks like that should be bring skipped. If I look at that test in #67114, it is marked to be skipped:

@pytest.mark.skip_on_darwin(reason="service.running is currently failing on OSX")

So pyest.mark.skip_on_darwin comes from pytest-skip-markers. Wondered if it was an issue with pytest-skip-markers on GH runners... but a simple test with a test repo shows @pytest.mark.skip_on_darwin to work.

Looks like there's some more complex reason why @pytest.mark.skip_on_darwin is getting ignored. Setting up some tests to try to debug further.

[barneysowood]

Ok, so looks like the issue was actually the _check_systemctl() and check_hostnamectl() functions that are being used in a @pytest.mark.skipif marker in these test files:

tests/integration/modules/test_localemod.py
tests/integration/modules/test_timezone.py
tests/pytests/functional/modules/test_service.py
tests/pytests/functional/modules/test_system.py
tests/pytests/functional/states/test_service.py
tests/pytests/unit/states/test_service.py

the original functions tried to run systemctl to check the state of systemd. On Mac OS (or other non-Linux) systems, that fails as systemctl isn't available. Added a check that the system was linux and had the function return false if not. eg

--- a/tests/pytests/functional/modules/test_service.py
+++ b/tests/pytests/functional/modules/test_service.py
@@ -17,10 +17,14 @@ pytestmark = [

 def _check_systemctl():
     if not hasattr(_check_systemctl, "memo"):
-        proc = subprocess.run(["systemctl"], capture_output=True, check=False)
-        _check_systemctl.memo = (
-            b"Failed to get D-Bus connection: No such file or directory" in proc.stderr
-        )
+        if not salt.utils.platform.is_linux():
+            _check_systemctl.memo = False
+        else:
+            proc = subprocess.run(["systemctl"], capture_output=True, check=False)
+            _check_systemctl.memo = (
+                b"Failed to get D-Bus connection: No such file or directory"
+                in proc.stderr
+            )
     return _check_systemctl.memo

That works and and the Mac OS tests now pass (see this CI job). Not sure it's the best way to handle this - ideally you'd check if it's a systemd with systemd rather than just if it is Linux - @dwoz feel free to change how that works if you think there's a better way.

@dwoz - I can either wait for you to merge #67114 and then rebase and merge #67136 or if it's easier you can just cherry-pick 6b9336d

[dwoz]

@dwoz - I can either wait for you to merge #67114 and then rebase and merge #67136 or if it's easier you can just cherry-pick 6b9336d

@barneysowood ,

Great find, I've just merged my PR. So you can open a PR for these failures specifically.

[barneysowood]

@dwoz - I can either wait for you to merge #67114 and then rebase and merge #67136 or if it's easier you can just cherry-pick 6b9336d

@barneysowood ,

Great find, I've just merged my PR. So you can open a PR for these failures specifically.

Thanks - that's now in a PR ready for review/merging - #67138