Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds virtual screening submission format #62

Merged
merged 8 commits into from
Nov 14, 2019
Merged

Adds virtual screening submission format #62

merged 8 commits into from
Nov 14, 2019

Conversation

davidlmobley
Copy link
Contributor

Adds virtual screening submission format and additional information on handling of that component. Also clarifies how this will work to hopefully address #60 -- breaking out analysis by site.

@davidlmobley
Copy link
Contributor Author

@haroldgrosjean can you check this and see if it looks OK?

Would be good also have to have a @MehtapIsik and/or @bergazin check.

@bergazin bergazin self-requested a review November 13, 2019 17:18
Copy link
Collaborator

@bergazin bergazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@MehtapIsik MehtapIsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consistently refer to this component as "Stage 1" instead of Phase 1 or virtual screening component.

I suggest renaming the screening_format.txt file as stage1_submission_template.txt. I think participants can find this file easier if the submission template is in the name. It will also be clearer in the future when the repo contains multiple stages which submission template is which.

## Overall participation instructions

Instructions on overall participation in this challenge/challenge rules are given in [../protein_ligand_instructions.md](../protein_ligand_instrucitons.md). This document provides challenge details as well as specifics for each stage.

## Phase 1: Discrimination of binders from non-binders at specific sites
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title should be "Stage 1" instead of "Phase 1" here to be consistent. We have decided to use the phase term for groups of SAMPL challenges such as SAMPL6, SAMPL7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@MehtapIsik
Copy link
Collaborator

I added a description for the following method categories:
Docking, Ligand-based, MD, ML, Other, Null.

I replaced simulation with MD because in some sources docking is also referred as simulation. I also thought it would be a good idea to let people assign multiple categories instead of a mixed category. I added instructions to separate multiple categories with a comma.

Are these categories and descriptions appropriate?

I included category descriptions both in submission template and the /protein_ligand/README file. If you prefer we can remove the descriptions from the submission file.

@davidlmobley
Copy link
Contributor Author

I think those categories are appropriate. I'll review the descriptions and edit directly if needed.

@davidlmobley davidlmobley merged commit 1f74e76 into master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants