Skip to content

Commit

Permalink
Removing Rubocop exclusions
Browse files Browse the repository at this point in the history
The two remove exclusions have since been "fixed" in the upstream
Rubocop releases. As such, there is no reason to have these exclusions.

Thank you @jcoyne and @dunn for the comments that helped me review if
I could remove these exclusions.
  • Loading branch information
jeremyf committed Feb 2, 2020
1 parent ace4a76 commit 2bbafe7
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions .rubocop_fixme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,9 @@ Naming/PredicateName:
Exclude:
- 'app/helpers/hyrax/collections_helper.rb'


# TODO: remove when https://github.com/bbatsov/rubocop/issues/4539 is fixed
Style/FormatStringToken:
Exclude:
- 'config/routes.rb'

Style/DateTime:
Enabled: false

# TODO: remove when https://github.com/bbatsov/rubocop/issues/5161 is fixed
Style/CommentedKeyword:
Exclude:
- 'app/models/vocab/fedora_resource_status.rb'

Style/SpecialGlobalVars:
Exclude:
- 'tasks/hyrax_dev.rake'
Expand Down

0 comments on commit 2bbafe7

Please sign in to comment.