From 9ea6cd885ff36ed63d72c219e31c1f63bc6e7e70 Mon Sep 17 00:00:00 2001 From: "Michael J. Giarlo" Date: Thu, 3 Aug 2017 09:45:31 -0700 Subject: [PATCH 1/2] Remove incorrect TODO comment This is a documented service that folks can use in their own rake tasks, etc. --- app/services/hyrax/repository_fixity_check_service.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/app/services/hyrax/repository_fixity_check_service.rb b/app/services/hyrax/repository_fixity_check_service.rb index 47fc87fe6e..54e6a59267 100644 --- a/app/services/hyrax/repository_fixity_check_service.rb +++ b/app/services/hyrax/repository_fixity_check_service.rb @@ -1,6 +1,5 @@ module Hyrax class RepositoryFixityCheckService - # TODO: this never seems to be used. Remove? def self.fixity_check_everything ::FileSet.find_each do |gf| Hyrax::FileSetFixityCheckService.new(gf).fixity_check From 07940b4c6e8d2f27edac1b93b419f668d7c9e775 Mon Sep 17 00:00:00 2001 From: "Michael J. Giarlo" Date: Fri, 4 Aug 2017 13:31:45 -0700 Subject: [PATCH 2/2] Improve comment in fixity check service --- app/services/hyrax/repository_fixity_check_service.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/services/hyrax/repository_fixity_check_service.rb b/app/services/hyrax/repository_fixity_check_service.rb index 54e6a59267..1ffadc0f0e 100644 --- a/app/services/hyrax/repository_fixity_check_service.rb +++ b/app/services/hyrax/repository_fixity_check_service.rb @@ -1,8 +1,11 @@ module Hyrax class RepositoryFixityCheckService + # This is a service that folks can use in their own rake tasks, + # etc. It is not otherwise called or relied upon in Hyrax. + # @see https://github.com/samvera/hyrax/wiki/Hyrax-Management-Guide#fixity-checking def self.fixity_check_everything - ::FileSet.find_each do |gf| - Hyrax::FileSetFixityCheckService.new(gf).fixity_check + ::FileSet.find_each do |file_set| + Hyrax::FileSetFixityCheckService.new(file_set).fixity_check end end end