From c9b9869c4ce3d01f632321cbfd157623730d20f5 Mon Sep 17 00:00:00 2001
From: "E. Lynette Rayle" <elr37@cornell.edu>
Date: Fri, 15 Mar 2019 16:01:06 -0400
Subject: [PATCH] rename objects to child_objects

Use consistent naming in methods that also provides information on the direction of the relationship to make methods easier to grok.
---
 README.md                                          |  1 +
 .../pcdm/models/concerns/pcdm_valkyrie_behavior.rb | 12 +++++++-----
 .../models/concerns/pcdm_valkyrie_behavior_spec.rb | 14 +++++++-------
 3 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index b5984387a6..17e4fe8e0c 100644
--- a/README.md
+++ b/README.md
@@ -345,3 +345,4 @@ This software has been developed by and is brought to you by the Samvera communi
 [Samvera website](http://samvera.org/).
 
 ![Samvera Logo](https://wiki.duraspace.org/download/thumbnails/87459292/samvera-fall-font2-200w.png?version=1&modificationDate=1498550535816&api=v2)
+ 
\ No newline at end of file
diff --git a/lib/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior.rb b/lib/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior.rb
index 562ff4b5ad..5c8ae4081c 100644
--- a/lib/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior.rb
+++ b/lib/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior.rb
@@ -35,20 +35,22 @@ def parent_collection_ids(valkyrie: false)
       # Gives the subset of #members that are PCDM objects
       # @return [Enumerable<ActiveFedora::Base> | Enumerable<Valkyrie::Resource>] an enumerable over the members
       #   that are PCDM objects
-      def objects(valkyrie: false)
+      def child_objects(valkyrie: false)
         af_objects = Wings::ActiveFedoraConverter.new(resource: self).convert.objects
         return af_objects unless valkyrie
         af_objects.map(&:valkyrie_resource)
       end
-      alias members objects
-      alias ordered_members objects
+      alias objects child_objects
+      alias members child_objects
+      alias ordered_members child_objects
 
       ##
       # Gives a subset of #member_ids, where all elements are PCDM objects.
       # @return [Enumerable<String> | Enumerable<Valkyrie::ID] the object ids
-      def object_ids(valkyrie: false)
-        objects(valkyrie: valkyrie).map(&:id)
+      def child_object_ids(valkyrie: false)
+        child_objects(valkyrie: valkyrie).map(&:id)
       end
+      alias object_ids child_object_ids
     end
   end
 end
diff --git a/spec/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior_spec.rb b/spec/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior_spec.rb
index 8604ff6f18..9741f62eb6 100644
--- a/spec/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior_spec.rb
+++ b/spec/wings/hydra/pcdm/models/concerns/pcdm_valkyrie_behavior_spec.rb
@@ -143,7 +143,7 @@
     # end
   end
 
-  describe '#objects' do
+  describe '#child_objects' do
     let(:pcdm_object) { collection1 }
 
     before do
@@ -153,7 +153,7 @@
 
     context 'when valkyrie resources requested' do
       it 'returns works only as valkyrie resources through pcdm_valkyrie_behavior' do
-        resources = resource.objects(valkyrie: true)
+        resources = resource.child_objects(valkyrie: true)
         expect(resources.size).to eq 2
         expect(resources.first.pcdm_object?).to be true
         expect(resources.map(&:id)).to match_valkyrie_ids_with_active_fedora_ids([work1.id, work2.id])
@@ -161,7 +161,7 @@
     end
     context 'when active fedora objects requested' do
       it 'returns works only as fedora objects through pcdm_valkyrie_behavior' do
-        af_objects = resource.objects(valkyrie: false)
+        af_objects = resource.child_objects(valkyrie: false)
         expect(af_objects.size).to eq 2
         expect(af_objects.first.pcdm_object?).to be true
         expect(af_objects.map(&:id)).to match_array [work1.id, work2.id]
@@ -169,7 +169,7 @@
     end
     context 'when return type is not specified' do
       it 'returns works only as fedora objects through pcdm_valkyrie_behavior' do
-        af_objects = resource.objects
+        af_objects = resource.child_objects
         expect(af_objects.size).to eq 2
         expect(af_objects.first.pcdm_object?).to be true
         expect(af_objects.map(&:id)).to match_array [work1.id, work2.id]
@@ -187,21 +187,21 @@
 
     context 'when valkyrie resources requested' do
       it 'returns ids of works only as valkyrie resources through pcdm_valkyrie_behavior' do
-        resource_ids = resource.object_ids(valkyrie: true)
+        resource_ids = resource.child_object_ids(valkyrie: true)
         expect(resource_ids.size).to eq 2
         expect(resource_ids).to match_valkyrie_ids_with_active_fedora_ids([work1.id, work2.id])
       end
     end
     context 'when active fedora objects requested' do
       it 'returns ids of works only as fedora objects through pcdm_valkyrie_behavior' do
-        af_object_ids = resource.object_ids(valkyrie: false)
+        af_object_ids = resource.child_object_ids(valkyrie: false)
         expect(af_object_ids.size).to eq 2
         expect(af_object_ids.to_a).to match_array [work1.id, work2.id]
       end
     end
     context 'when return type is not specified' do
       it 'returns ids of works only as fedora objects through pcdm_valkyrie_behavior' do
-        af_object_ids = resource.object_ids
+        af_object_ids = resource.child_object_ids
         expect(af_object_ids.size).to eq 2
         expect(af_object_ids.to_a).to match_array [work1.id, work2.id]
       end