Merge pull request #5552 from samvera/5551-child-search

Ensure excluded work id is a String
samvera · Mar 17, 2022 · f050d8f · f050d8f
2 parents c084ac5 + b4c8eb2
commit f050d8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/app/views/hyrax/base/_form_child_work_relationships.html.erb b/app/views/hyrax/base/_form_child_work_relationships.html.erb
@@ -18,7 +18,7 @@ HTML Properties:
                         data: {
                           autocomplete: 'work',
                           'autocomplete-url' => Rails.application.routes.url_helpers.qa_path + '/search/find_works',
-                          'exclude-work': f.object.model.id # exclude this item from the result set.
+                          'exclude-work': f.object.model.id.to_s # exclude this item from the result set.
                         } %>
       <a href="#" onclick="return false;" class="btn btn-primary" data-behavior="add-relationship"><%= t('.add') %></a>
   </div>

diff --git a/spec/views/hyrax/base/_form_child_work_relationships.html.erb_spec.rb b/spec/views/hyrax/base/_form_child_work_relationships.html.erb_spec.rb
@@ -31,6 +31,7 @@
 
         # input with add button
         expect(rendered).to have_selector('input[data-autocomplete-url="/authorities/search/find_works"]')
+        expect(rendered).to have_selector("[data-exclude-work='#{work.id}']")
         expect(rendered).to have_selector("[data-behavior='add-relationship']")
       end
     end
@@ -44,6 +45,7 @@
       it "draws the page" do
         # input with add button
         expect(rendered).to have_selector('input[data-autocomplete-url="/authorities/search/find_works"]')
+        expect(rendered).to have_selector("[data-exclude-work='#{work.id}']")
         expect(rendered).to have_selector("[data-behavior='add-relationship']")
 
         # generate the json to drive the script