Add tests for new breadcrumbs

samvera · Mar 28, 2018 · f9fcbe5 · f9fcbe5
1 parent 9adb2eb
commit f9fcbe5
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 6 deletions.
diff --git a/app/controllers/concerns/hyrax/embargoes_controller_behavior.rb b/app/controllers/concerns/hyrax/embargoes_controller_behavior.rb
@@ -7,7 +7,7 @@ module EmbargoesControllerBehavior
     def index
       add_breadcrumb t(:'hyrax.controls.home'), root_path
       add_breadcrumb t(:'hyrax.dashboard.breadcrumbs.admin'), hyrax.dashboard_path
-      add_breadcrumb t(:'hyrax.embargoes.index.manage_embargoes', hyrax.embargoes_path)
+      add_breadcrumb t(:'hyrax.embargoes.index.manage_embargoes'), hyrax.embargoes_path
       authorize! :index, Hydra::AccessControls::Embargo
     end
 
@@ -43,5 +43,12 @@ def update
     def self.local_prefixes
       ['hyrax/base']
     end
+
+    def edit
+      add_breadcrumb t(:'hyrax.controls.home'), root_path
+      add_breadcrumb t(:'hyrax.dashboard.breadcrumbs.admin'), hyrax.dashboard_path
+      add_breadcrumb t(:'hyrax.embargoes.index.manage_embargoes'), hyrax.embargoes_path
+      add_breadcrumb t(:'hyrax.embargoes.edit.embargo_update'), '#'
+    end
   end
 end
diff --git a/app/controllers/concerns/hyrax/leases_controller_behavior.rb b/app/controllers/concerns/hyrax/leases_controller_behavior.rb
@@ -7,7 +7,7 @@ module LeasesControllerBehavior
     def index
       add_breadcrumb t(:'hyrax.controls.home'), root_path
       add_breadcrumb t(:'hyrax.dashboard.breadcrumbs.admin'), hyrax.dashboard_path
-      add_breadcrumb t(:'hyrax.leases.index.manage_leases', hyrax.leases_path)
+      add_breadcrumb t(:'hyrax.leases.index.manage_leases'), hyrax.leases_path
       authorize! :index, Hydra::AccessControls::Lease
     end
 
@@ -36,5 +36,12 @@ def update
     def self.local_prefixes
       ['hyrax/base']
     end
+
+    def edit
+      add_breadcrumb t(:'hyrax.controls.home'), root_path
+      add_breadcrumb t(:'hyrax.dashboard.breadcrumbs.admin'), hyrax.dashboard_path
+      add_breadcrumb t(:'hyrax.leases.index.manage_leases'), hyrax.leases_path
+      add_breadcrumb t(:'hyrax.leases.edit.lease_update'), '#'
+    end
   end
 end
diff --git a/app/controllers/concerns/hyrax/manages_embargoes.rb b/app/controllers/concerns/hyrax/manages_embargoes.rb
@@ -13,9 +13,6 @@ def deny_access(exception)
       redirect_to root_path, alert: exception.message
     end
 
-    def edit
-      add_breadcrumb t(:'hyrax.controls.home'), root_path
-      add_breadcrumb t(:'hyrax.dashboard.breadcrumbs.admin'), hyrax.dashboard_path
-    end
+    def edit; end
   end
 end
diff --git a/spec/controllers/hyrax/embargoes_controller_spec.rb b/spec/controllers/hyrax/embargoes_controller_spec.rb
@@ -15,6 +15,9 @@
       let(:user) { create(:user, groups: ['admin']) }
 
       it 'shows me the page' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Manage Embargoes', embargoes_path)
         get :index
         expect(response).to be_success
         expect(response).to render_template('dashboard')
@@ -32,6 +35,10 @@
     end
     context 'when I have permission to edit the object' do
       it 'shows me the page' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Manage Embargoes', embargoes_path)
+        expect(controller).to receive(:add_breadcrumb).with('Update Embargo', '#')
         get :edit, params: { id: a_work }
         expect(response).to be_success
         expect(response).to render_template('dashboard')

diff --git a/spec/controllers/hyrax/leases_controller_spec.rb b/spec/controllers/hyrax/leases_controller_spec.rb
@@ -16,6 +16,10 @@
       let(:user) { create(:user, groups: ['admin']) }
 
       it 'shows me the page' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Manage Leases', leases_path)
+
         get :index
         expect(response).to be_success
         expect(response).to render_template('dashboard')
@@ -33,6 +37,11 @@
     end
     context 'when I have permission to edit the object' do
       it 'shows me the page' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Manage Leases', leases_path)
+        expect(controller).to receive(:add_breadcrumb).with('Update Lease', '#')
+
         get :edit, params: { id: a_work }
         expect(response).to be_success
         expect(response).to render_template('dashboard')