Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Message magic" regexps are too greedy #1

Open
apparentlymart opened this issue Feb 25, 2016 · 0 comments
Open

"Message magic" regexps are too greedy #1

apparentlymart opened this issue Feb 25, 2016 · 0 comments

Comments

@apparentlymart
Copy link
Collaborator

We currently match the special "deploy to" messages using regexps that capture the environment name using \S+.

This is too greedy because it prevents writing messages like Deploy #12 to foo: baz. In that case, the environment name is parsed as "foo:".

Instead we should make this more restrictive with something like [\w\.\-]+. That allows environment names to either be identifier-ish strings or hostnames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant