-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display ENS Avatar if user has ENS #102
Comments
Hey @gotnoshoeson thank for opening the issue. We've talked about this a few times and I think it's a good idea! If we haven't implemented it yet it's because we were worried about performance, and were thinking about caching ideas. Hitting the
Are you using any caching mechanism? Are you using an API or RPC calls? Feel to open a draft PR and we can discuss there. Thanks. |
Thanks @carletex , Realizing that my solution isn't very optimized; I'm using my own firebase db so it's pretty fast with only 5 users :) Currently utilizing RPC calls. I'm now thinking a more scalable/optimized solution would be to hit the ENS subgraph endpoint with an array of builder addresses as an argument variable, that'd be one request/one response with all the needed data. I'll open a PR with this method. |
This sounds great! Grouping addresses in a single request would save a lot. My other idea was to cache it in Firebase (as we do with ENS names**). ** We save the resolved ENS name when a builder is created in the system. We'd also need a cron job to update (not happening at the moment). The other issue is that pages like Anyway, just thinking out loud! Feel free to PR and we can work from there. Related: I found this too https://metadata.ens.domains/docs#/paths/~1%7BnetworkName%7D~1avatar~1%7Bname%7D/get. An API for getting ENS data :D Thanks again for working on this, man! |
Display ENS Avatar if builder has an ENS. Continue using QRPunkBlockie if builder doesn't have ENS or if their ENS avatar isn't set.
Will affect the following components:
I pretty much have this working already.
The text was updated successfully, but these errors were encountered: