Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable tests #58

Open
f1ames opened this issue Apr 21, 2022 · 0 comments
Open

Unstable tests #58

f1ames opened this issue Apr 21, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@f1ames
Copy link
Contributor

f1ames commented Apr 21, 2022

I have noticed recently that CI is being unstable and some tests are failing from time to time. It seems to be the case of pipe tests mostly:

  streams › data › native-interface › Piped DataStream can be unpiped via '.unpipe(instance)' #2

  build/test/unit/streams/data/native-interface.spec.js:109

   108:             await stream.end();                                
   109:             t.deepEqual(await stream.toArray(), ["fo", "o\n"]);
   110:             resolve();                                         

  Difference:

    [
      'fo',
  +   `o␊
  +   `,
    ]

  › ReadStream.<anonymous> (build/test/unit/streams/data/native-interface.spec.js:109:15)



  streams › data › native-interface › Piped DataStream can be unpiped via '.unpipe()' #2

  build/test/unit/streams/data/native-interface.spec.js:145

   144:             await stream.end();                                
   145:             t.deepEqual(await stream.toArray(), ["fo", "o\n"]);
   146:             resolve();                                         

  Difference:

    [
      'fo',
  +   `o␊
  +   `,
    ]

  › ReadStream.<anonymous> (build/test/unit/streams/data/native-interface.spec.js:145:15)

  ─

  2 tests failed
  5 tests skipped

This may mean there is some issue with how it works internally.

@f1ames f1ames added the bug Something isn't working label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant