This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Improves the security headers #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgreinho
force-pushed
the
issues/194/security-headers
branch
from
48b64b2
to
cdb3b7f
Compare
ghost
reviewed
Jan 26, 2020
|
Ah good catch! The HMR did not catch the bad changes. I fixed the issue you mentioned, but no the CSP rules are too strict, and the site does not render properly. I'll keep working on the CSP rules. |
Attempts to fix all the security issues reported by the Mozilla Observatory: https://observatory.mozilla.org/analyze/viz.scrapd.org Fixes #194
rgreinho
force-pushed
the
issues/194/security-headers
branch
from
cdb3b7f
to
e6ab24f
Compare
|
This may help tweaking the CSPs: https://www.cspisawesome.com/. |
|
This too for mapbox tiles: https://docs.mapbox.com/mapbox-gl-js/overview/ |
Attempts to fix all the security issues reported by the Mozilla Observatory: https://observatory.mozilla.org/analyze/viz.scrapd.org Fixes #194
|
Alright @tom-nook, these values should do the trick! |
ghost
approved these changes
Jan 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Attempts to fix all the security issues reported by the Mozilla
Observatory: https://observatory.mozilla.org/analyze/viz.scrapd.org
Checklist
Fixes #194