Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting specific stains when reading merscope files into a sdata object. #250

Open
omiethescientist opened this issue Dec 12, 2024 · 3 comments

Comments

@omiethescientist
Copy link

The merscope image files that I use are currently quite big, and it is often useful for me to only select specific stains. Currently it is hard coded in the merscope function to read in all stains. However, it is an option in the _rioxarray_load_merscope function. It would be nice to set this ourselves as one of the kwargs or as a keyword argument in the merscope function itself.

@LucaMarconato
Copy link
Member

Hi @omiethescientist and thanks for the suggestion. Would you like to try making a PR for addressing this? We chose to keep spatialdata separate from spatialdata-io to encourage contributions from the community and I think this addition would be useful for the other users.

@omiethescientist
Copy link
Author

Sorry for the late response @LucaMarconato. Yes, I could definitely get a small PR done for this. I already have a small fix that allows you to include it as an additional kwarg in imread_kwargs. However, I know the code could be cleaner if I just passed it as an additional keyword argument in the funciton. What do you think?

@LucaMarconato
Copy link
Member

Yes @omiethescientist, sounds good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants