Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with new thermostat types #658

Open
razor-x opened this issue Sep 20, 2024 · 2 comments · Fixed by #659
Open

Fix compatibility with new thermostat types #658

razor-x opened this issue Sep 20, 2024 · 2 comments · Fixed by #659
Assignees

Comments

@razor-x
Copy link
Collaborator

razor-x commented Sep 20, 2024

Basic thermostat control should still work, but anything related to climate setting schedules will need to be removed and brought back later as climate presets plus thermostat schedules.

The most important thing is to fix any type errors with the latest types, as this will block users from updating.

@razor-x
Copy link
Collaborator Author

razor-x commented Oct 21, 2024

@mikewuu I merged the last PR into the beta branch. We can keep working off of beta until we finish making breaking changes.

  1. I found is_climate_setting_schedule_active. Can you search for any other instances of climate_setting_schedule or similar?
  2. We should remove climate_setting_schedules from fake-seam-connect as well.
  3. Let's remove manual_override_allowed and is_temporary_manual_override_active and related stuff. Those API are also changing.

@mikewuu
Copy link
Contributor

mikewuu commented Oct 22, 2024

@razor-x removed a couple stragglers in #661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants