Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger any open PRs #26

Open
cryptiklemur opened this issue Dec 13, 2019 · 2 comments
Open

Trigger any open PRs #26

cryptiklemur opened this issue Dec 13, 2019 · 2 comments

Comments

@cryptiklemur
Copy link

Seems like this triggers updates on any branches that have a PR to the default branch, regardless if they are open or closed.

It should only trigger on open PRs, and should also trigger on PRs that are from forks

@zsims
Copy link
Contributor

zsims commented May 14, 2020

and should also trigger on PRs that are from forks

This is covered in the readme -- you have to enable building forks, with all the security considerations.

It should only trigger on open PRs

Unfortunately this won't be possible unless we look at the API. This is when it starts to bleed into what Buildkite is doing -- ideally you have the hook setup to only build PRs (as they're opened) rather than when the branch is pushed

@cryptiklemur
Copy link
Author

ideally you have the hook setup to only build PRs (as they're opened) rather than when the branch is pushed

Unless i'm misunderstanding, any time a PR is pushed to, it ideally should build, not just when it opens

This is covered in the readme -- you have to enable building forks, with all the security considerations.

I don't see the word fork anywhere in the readme. It happens to be in the screenshot, but thats unrelated to the issue I was seeing when i tried this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants