Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Flatten objects #3

Open
jpknegtel opened this issue Nov 3, 2015 · 3 comments
Open

Flatten objects #3

jpknegtel opened this issue Nov 3, 2015 · 3 comments
Labels
migrated The issue has been migrated

Comments

@jpknegtel
Copy link

Tried to pass an address object however this is can not be translated into seperate object into woopra.

[object Object] is what is seen in woopra under user address field.

This is what is passed from Segment:
address: {
city: 'Amsterdam',
country: 'NL',
county: 'Noord-Holland',
housenumber: '',
postalcode: '1032 HP',
street: '
'
},

** taken out as personal info.

Should we just not use objects?

@sperand-io
Copy link
Contributor

@jpknegtel if the tool doesn't support a certain data structure, we should be flattening/coercing them into something readable by the tool. It's worth mentioning, however, that it may not be ideal for downstream analysis.

We should definitely add flattening here!

@sperand-io sperand-io changed the title Using objects Flatten objects Nov 11, 2015
@hankim813
Copy link
Contributor

@sperand-io @jpknegtel The stringification of objects was submitted by Ralph from Woopra's dev team but it looks like we are not doing that for traits:

https://github.com/segment-integrations/analytics.js-integration-woopra/blob/master/lib/index.js#L87

We are only doing for .track() properties:

https://github.com/segment-integrations/analytics.js-integration-woopra/blob/master/lib/index.js#L109

So I'm assuming that doing the same would work for traits?

@SegmentDestinationsBot
Copy link
Contributor

Hi @jpknegtel, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.

@SegmentDestinationsBot SegmentDestinationsBot added the migrated The issue has been migrated label Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migrated The issue has been migrated
Projects
None yet
Development

No branches or pull requests

4 participants