Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix #3161 break on ROCm #3289

Closed
5 tasks done
HaiShaw opened this issue Feb 4, 2025 · 3 comments
Closed
5 tasks done

[Bug] Fix #3161 break on ROCm #3289

HaiShaw opened this issue Feb 4, 2025 · 3 comments
Assignees

Comments

@HaiShaw
Copy link
Collaborator

HaiShaw commented Feb 4, 2025

Checklist

  • 1. I have searched related issues but cannot get the expected help.
  • 2. The bug has not been fixed in the latest version.
  • 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
  • 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
  • 5. Please use English, otherwise it will be closed.

Describe the bug

#3161 breaks AMD build, to fix.

Reproduction

AMD CI!

Environment

AMD ROCm

@HaiShaw HaiShaw self-assigned this Feb 4, 2025
@Fridge003
Copy link
Collaborator

@HaiShaw Hi, could you please post the error traceback.

@Fridge003
Copy link
Collaborator

This issue has been fixed @zhaochenyang20

@zhaochenyang20
Copy link
Collaborator

great! @Fridge003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants