068.md

Petite Pewter Orangutan

High

LenderCommitmentGroupShares missing msg.sender on constructor's Ownable()

Summary

LenderCommitmentGroupShares missing msg.sender on constructor's Ownable()

Impact

It will not be possible to deploy the contract with the correct ownership.

PoC

LenderCommitmentGroupShares::constructor

    constructor(string memory _name, string memory _symbol, uint8 _decimals)
        ERC20(_name, _symbol)
@>      Ownable()
    {
        DECIMALS = _decimals;
    }

Mitigation

Add msg.sender on the constructor's Ownable()

    constructor(string memory _name, string memory _symbol, uint8 _decimals)
        ERC20(_name, _symbol)
-       Ownable()
+       Ownable(msg.sender)
    {
        DECIMALS = _decimals;
    }