Dandy Caramel Tortoise - Using .approve will cause bidding to revert in LenderCommitmentGroup_Smart.sol

[sherlock-admin3]

Dandy Caramel Tortoise

Medium

Using .approve will cause bidding to revert in LenderCommitmentGroup_Smart.sol

Summary

Using .approve will cause bidding to revert in LenderCommitmentGroup_Smart.sol

Root Cause

.approve is used expecting a boolean return variable which will revert for USDT since it doesn't return anything. The team specifically plans to support USDT

        principalToken.approve(address(TELLER_V2), _principalAmount);

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

Bidding in LenderCommitmentGroup_Smart will revert for USDT

PoC

No response

Mitigation

Use .safeApprove instead

[sherlock-admin2]

The protocol team fixed this issue in the following PRs/commits:
teller-protocol/teller-protocol-v2-audit-2024#78