Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gorgeous Cobalt Frog - Markets that have been created with the removed Market Config will keep on selling and buying votes #130

Open
sherlock-admin4 opened this issue Dec 30, 2024 · 0 comments

Comments

@sherlock-admin4
Copy link
Contributor

Gorgeous Cobalt Frog

Medium

Markets that have been created with the removed Market Config will keep on selling and buying votes

Summary

removeMarketConfig() allows the owner to controle the :
liquidity, basePrice, creationCost
the issue is that the already created market will keep existing, this may lead to a critical issues
as a malicious user could abuse the removed liquidity parameter, which makes it possible to drain funds
from the market

Root Cause

  1. if the owner updates the MarketConfig.liquidity for a critical reason
  2. with the price going up and down the MarketConfig.liquidity parameter could be an issue in the calculation, and there is no mechanism that's allow the owner to control existing markets.

Internal Pre-conditions

Using a Logarithmic Market Scoring Rule (LMSR), vote prices fluctuate dynamically based on demand, when the demand is high the code is designed to allow the owner to update the MarketConfig.liquidity to prevent funds draining.

External Pre-conditions

No response

Attack Path

No response

Impact

Owner is prevented from one of the key functionalities.

PoC

The Protocol allows the Owner to addMarketConfig() and removeMarketConfig() .
but there is no mechanism to change the created markets parameters.

Mitigation

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant