We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3_POS_MGR
Base
V3Locker
Chilly Wool Ladybug
Medium
V3_POS_MGR is set to a hardcoded address in the constructor which is incorrect on the Base chain, breaking the V3Locker contract on that chain.
constructor() Ownable(_msgSender()) { CREATED = block.timestamp; V3_POS_MGR = INonfungiblePositionManager(0xC36442b4a4522E871399CD717aBDD847Ab11FE88); }
0xC36442b4a4522E871399CD717aBDD847Ab11FE88 is the address of the PositionManager on Mainnet, but not on Base
0xC36442b4a4522E871399CD717aBDD847Ab11FE88
//https://docs.uniswap.org/contracts/v3/reference/deployments/base-deployments NonfungiblePositionManager | 0x03a520b32C04BF3bEEf7BEb72E919cf822Ed34f1
None
Deploying the contract V3Locker would simply revert.
V3Locker is unusable as it is on Base. This is one of the chains mentioned on the contest page, and Base supports UniswapV3 Pools.
No response
To make it more flexible and easy to deploy on several chains, simply pass the address argument in the constructor
address
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Chilly Wool Ladybug
Medium
Incorrect address of
V3_POS_MGR
onBase
would breakV3Locker
Summary
V3_POS_MGR
is set to a hardcoded address in the constructor which is incorrect on theBase
chain, breaking theV3Locker
contract on that chain.Root Cause
0xC36442b4a4522E871399CD717aBDD847Ab11FE88
is the address of the PositionManager on Mainnet, but not on BaseInternal Pre-conditions
None
External Pre-conditions
None
Attack Path
Deploying the contract
V3Locker
would simply revert.Impact
V3Locker
is unusable as it is onBase
. This is one of the chains mentioned on the contest page, andBase
supports UniswapV3 Pools.PoC
No response
Mitigation
To make it more flexible and easy to deploy on several chains, simply pass the
address
argument in the constructorThe text was updated successfully, but these errors were encountered: