Sneaky Zinc Narwhal - some variable have to be update before in the unstake function

[sherlock-admin4]

Sneaky Zinc Narwhal

High

some variable have to be update before in the unstake function

Summary

in the contract VotingPool function unstake should have to first update _stake.stakedToOutputDenomenator) _stake.stakedToOutputFactor; before calculating _amtStakeToRemove in line 51 to get the real time burn amount

  uint256 _amtStakeToRemove = (_amount * _stake.stakedToOutputDenomenator) / _stake.stakedToOutputFactor;
        _stake.amtStaked -= _amtStakeToRemove;

https://github.com/sherlock-audit/2025-01-peapods-finance/blob/main/contracts/contracts/voting/VotingPool.sol#L51

Root Cause

in VotingPool the _stake.stakedToOutputDenomenator) _stake.stakedToOutputFactor; arent updated

Internal Pre-conditions

nothing

External Pre-conditions

nothing

Attack Path

nothing

Impact

WRONG VALUE WILL BE BURNED

PoC

No response

Mitigation

No response