-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splunksql
: Add splunksql.OpenDB
function
#106
Comments
Waiting until anyone asks for this feature. |
splunksql.OpenDB
functionsplunksql
: Add splunksql.OpenDB
function
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi, we want |
@joshi-kamitsukasa Could you please add a snippet how would you use such function? My guess is that it would rather prefer using Of course we would need to create If you would like to have this sooner rather than later, please contact Splunk's support/sales to escalate this issue. More: https://docs.splunk.com/observability/en/get-started/support.html |
@pellared Thanks for your reply. For example below,
We are going to contact support. Thanks. |
Add
splunksql.OpenDB
function for ones who dislike thesql.Open
andsplunksql.Open
which use global state.Something similar to https://pkg.go.dev/github.com/XSAM/otelsql#OpenDB
Desired API:
func OpenDB(c driver.Connector, cfg InstrumentationConfig) *sql.DB
.We should also add
OpenDB
functions to all other sql-based instrumentation libraries that will usesplunksql.OpenDB
.Implementation guidelines: #88 (comment)
Originally posted by @pellared in #88 (comment)
The text was updated successfully, but these errors were encountered: