Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add Change IP Confirmation #633

Open
marchelzi opened this issue Feb 24, 2025 · 1 comment
Open

[Feature Request]: Add Change IP Confirmation #633

marchelzi opened this issue Feb 24, 2025 · 1 comment
Labels
enhancement New feature or request pinned Does not stale

Comments

@marchelzi
Copy link

🚀 Feature Summary

The proposed feature is to add a confirmation dialog when the user attempts to change the IP segment for a managed device. This is to prevent accidental changes that could lead to the removal of all managed routes, which can be disruptive to the network.

📝 Detailed Description

Currently, when a user changes the IP segment for a managed device in the ztnet application, the change is applied immediately without any confirmation. This can lead to issues if the user accidentally enters the wrong IP segment, as it will result in the removal of all managed routes for that device.

The proposed feature is to add a confirmation dialog that appears when the user attempts to change the IP segment. This dialog should clearly explain the implications of the change, such as the removal of managed routes, and require the user to confirm the action before it is executed.

The expected benefits of this feature are:

  1. Reduced risk of accidental IP segment changes that could disrupt the network.
  2. Improved user experience by providing a clear warning and confirmation before a potentially destructive action is taken.
  3. Increased confidence in the ztnet application, as users will know that safeguards are in place to prevent unintended consequences.

🎯 Use Case

The primary use case for this feature is to prevent accidental changes to the IP segment of managed devices, which can lead to the removal of all managed routes. This is a critical issue that can have significant impact on the network, and adding a confirmation step will help mitigate the risk.

Additionally, this feature will be useful for users who need to make intentional changes to the IP segment, as it will provide them with a clear understanding of the consequences of their actions before proceeding.

💡 Willing to Contribute

Yes, I could help with coding

@marchelzi marchelzi added the enhancement New feature or request label Feb 24, 2025
@sinamics sinamics added the pinned Does not stale label Feb 24, 2025
@marchelzi
Copy link
Author

A pull request has already been created to address this feature request. You can find it referenced as #634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Does not stale
Projects
None yet
Development

No branches or pull requests

2 participants