-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding opendocument
and officedocument
templates mime ?
#709
Comments
🤔 Reading at the source code, maybe the only thing is to add some mime check here: Line 30 in 7e72bbc
I think that's worth a try. |
This is the formal MIME-type registration: https://www.iana.org/assignments/media-types/media-types.xhtml Many MIME-types which are in use, do unfortunately lack a formal registration at IANA. If that registration is missing, we can base it on the original specification, an RFC, Wikipedia, or any other reference which suggests what the best MIME-type is. It is required to document where you get it from, for traceability. If someone, has a better suggestion, we can easily trace where the existing type came from, and which one is the best to use. |
Thank you, I was answering in the closed PR. |
@sly7-7 , given you follow the same pattern with previous related PRs, I have no problem if you combine the remaining templates in a combined PR, do you agree @sindresorhus ? |
I'm on vacation, I will do that on Monday if @sindresorhus is ok with that |
👍 |
@Borewit @sindresorhus #718 is ready for review :) |
Description
Hello, at this time, it seems templates from ms office and openoffice/libreoffice templates are considered either
application/zip
or at best as there document counter parts. So I was wondering if it would be possible to better analyze these files. For example, using mime, it detects these mime types for the following extensions:ots: application/vnd.oasis.opendocument.spreadsheet-template
(application/zip for file-type) Add support for OpenDocument graphics and templates #718odg: application/vnd.oasis.opendocument.graphics
(application/zip for file-type) Add support for OpenDocument graphics and templates #718otg: application/vnd.oasis.opendocument.graphics-template
(application/zip) Add support for OpenDocument graphics and templates #718otp: application/vnd.oasis.opendocument.presentation-template
(application/zip for file-type) Add support for OpenDocument graphics and templates #718ott: application/vnd.oasis.opendocument.text-template
(application/zip for file-type) Add support for OpenDocument graphics and templates #718xltx: application/vnd.openxmlformats-officedocument.spreadsheetml.template
(application/vnd.openxmlformats-officedocument.spreadsheetml.sheet for file-type) Add support for Microsoft Excel template (.xltx
) #712xltm: application/vnd.ms-excel.template.macroenabled.12
(application/vnd.openxmlformats-officedocument.spreadsheetml.sheet for file-type) Add support for Microsoft Excel template with macros (.xltm) #714potx: application/vnd.openxmlformats-officedocument.presentationml.template
(application/vnd.openxmlformats-officedocument.presentationml.presentation for file-type) Add support for Microsoft PowerPoint template (.potx
) #710dotx: application/vnd.openxmlformats-officedocument.wordprocessingml.template
(application/vnd.openxmlformats-officedocument.wordprocessingml.document for file-type) Add support for Microsoft Word template (.dotx) #713I don't know much about mime types or file signatures, so I don't know they are good candidates, neither how to do the detections.
Existing Issue Check
File-Type Scope Acknowledgment
The text was updated successfully, but these errors were encountered: