operations_validation_test.go

package mcms

import (
	"encoding/json"
	"errors"
	"math/big"
	"testing"

	cselectors "github.com/smartcontractkit/chain-selectors"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/smartcontractkit/mcms/sdk/evm"
	"github.com/smartcontractkit/mcms/types"
)

// TODO: Should go to EVM SDK. This should just tests the router function actuallty routes to the correct chain
func TestValidateAdditionalFields(t *testing.T) {
	t.Parallel()

	validEVMFields := evm.AdditionalFields{Value: big.NewInt(100)}
	validEVMFieldsJSON, err := json.Marshal(validEVMFields)
	require.NoError(t, err)

	invalidEVMFields := evm.AdditionalFields{
		Value: big.NewInt(-100),
	}
	invalidEVMFieldsJSON, err := json.Marshal(invalidEVMFields)
	require.NoError(t, err)

	validSolanaFields := evm.AdditionalFields{Value: big.NewInt(2)}
	validSolanaFieldsJSON, err := json.Marshal(validSolanaFields)
	require.NoError(t, err)

	tests := []struct {
		name        string
		operation   types.Operation
		expectedErr error
	}{
		{
			name: "valid EVM fields",
			operation: types.Operation{
				ChainSelector: types.ChainSelector(cselectors.ETHEREUM_TESTNET_SEPOLIA.Selector),
				Transaction: types.Transaction{
					AdditionalFields: validEVMFieldsJSON,
				},
			},

			expectedErr: nil,
		},
		{
			name: "invalid EVM fields",
			operation: types.Operation{
				ChainSelector: types.ChainSelector(cselectors.ETHEREUM_TESTNET_SEPOLIA.Selector),
				Transaction: types.Transaction{
					AdditionalFields: invalidEVMFieldsJSON,
				},
			},
			expectedErr: errors.New("invalid EVM value"),
		},
		{
			name: "valid Solana fields",
			operation: types.Operation{
				ChainSelector: types.ChainSelector(cselectors.SOLANA_DEVNET.Selector),
				Transaction: types.Transaction{
					AdditionalFields: validSolanaFieldsJSON,
				},
			},
			expectedErr: nil,
		},
		{
			name: "unknown chain family",
			operation: types.Operation{
				ChainSelector: 999,
				Transaction: types.Transaction{
					AdditionalFields: nil,
				},
			},
			expectedErr: errors.New("family not found for selector 999"),
		},
		{
			name: "invalid JSON for EVM fields",
			operation: types.Operation{
				ChainSelector: types.ChainSelector(cselectors.ETHEREUM_TESTNET_SEPOLIA.Selector),
				Transaction: types.Transaction{
					AdditionalFields: []byte("invalid JSON"),
				},
			},
			expectedErr: errors.New("failed to unmarshal EVM additional fields"),
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()

			err := ValidateAdditionalFields(tt.operation.Transaction.AdditionalFields, tt.operation.ChainSelector)

			if tt.expectedErr != nil {
				require.Error(t, err)
				assert.Contains(t, err.Error(), tt.expectedErr.Error())
			} else {
				assert.NoError(t, err)
			}
		})
	}
}