New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Search Parameters #223

Open

Mec-iS opened this issue Nov 3, 2022 · 0 comments

Labels

good first issue

Milestone

Collaborator

Mec-iS commented Nov 3, 2022

Currently svm/search is disabled because of lack of deserialization for Kernel (see #221).

The current implementation requires cloning of the Kernel object, but as it is an object-safe trait cloning cannot be supported.
Options are:

use this library that implements dynClone: https://github.com/dtolnay/dyn-clone
use Rc<RefCell<dyn MyTrait>>: https://users.rust-lang.org/t/object-safety-and-cloning-traits/22620/3

It may be an option to have our own implementation of dynClone.

The text was updated successfully, but these errors were encountered:

Mec-iS added this to the v0.5 milestone

Mec-iS added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment